Skip to content

Conversation

@vvolkgang
Copy link
Member

🎟️ Tracking

N/A

📔 Objective

Used the wrong sdk version name to run the workflow that created #1909, manually updated the PR title and description, this PR fixes the code comment to match.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested review from a team and matt-livefront as code owners September 8, 2025 16:49
@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.23%. Comparing base (ddbbfee) to head (38aa16f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1919      +/-   ##
==========================================
- Coverage   88.65%   85.23%   -3.43%     
==========================================
  Files         814     1008     +194     
  Lines       51433    61316    +9883     
==========================================
+ Hits        45596    52260    +6664     
- Misses       5837     9056    +3219     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

Logo
Checkmarx One – Scan Summary & Detailsd1404380-f193-4838-8c93-35f1835fe905

Great job! No new security vulnerabilities introduced in this pull request

@vvolkgang vvolkgang merged commit f4e6593 into main Sep 8, 2025
12 checks passed
@vvolkgang vvolkgang deleted the vvolkgang-patch-1 branch September 8, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants